[ELY-2840] Upgrade okhttp3 mockwebserver#2266
Closed
abhisar-yadav wants to merge 2 commits intowildfly-security:2.xfrom
Closed
[ELY-2840] Upgrade okhttp3 mockwebserver#2266abhisar-yadav wants to merge 2 commits intowildfly-security:2.xfrom
abhisar-yadav wants to merge 2 commits intowildfly-security:2.xfrom
Conversation
Contributor
Author
|
please review my pr |
Contributor
Author
Contributor
Author
|
@darranl kindly review my pr |
Contributor
|
Hello @abhisar-yadav , sorry for late review. Please add a jira issue number on the beginning of commits and this can be merged. Thank you! |
Contributor
|
Superceded by #2319 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the
com.squareup.okhttp3.mockwebserverdependency from version3.xto4.0.0in the WildFly Elytron project.Changes Made:
version.com.squareup.okhttp3.mockwebserverproperty inpom.xmlfrom3.xto4.0.0.Testing Done:
mvn clean install -DskipTests.mvn test, and they passed without any issues.Please review and let me know if additional changes are required.
https://issues.redhat.com/browse/ELY-2840